MoxieCombine now exposes exactly images / audio / fps - the leftover
VIDEO and FILENAME_PREFIX outputs are gone, so the output file name is
chosen on easy saveVideo itself. The base easy multitrackProjectVideoCombine
keeps its VIDEO and FILENAME_PREFIX outputs for legacy workflows.
The shipped Moxie-consolidated template is rewired accordingly: fps/images
links follow the new slot indices (2/0), the filename_prefix link is replaced
by the same project-scoped literal the removed output produced, and the
TEMPLATE's save location is unchanged.
pytest: new schema/execute/blocker coverage for MoxieCombine via a
_load_moxie_combine helper; base-combine assertions untouched.
- the format combo on MultiTrack Editor and MultiTrack Project now
shows 'Moxie Multimedia' (FORMAT_DISPLAY_LABEL); every queued value
is normalized back to the internal 'MiniMax' value at both execute
entries and check_lazy_status, so tracks_info, conditioning caches,
saved manifests and frontend lookups are unchanged
- frontend: normalizeFormatValue() maps the display label back at the
format-widget read point so MiniMax-specific editor features keep
working; shipped templates carry the new label
- removed the per-run 'Output upscale' console line; the restore now
happens silently (one-shot fallback diagnostics kept)
Note: workflows saved before this change need the format re-picked
once, since 'MiniMax' is no longer a combo option.
The compose step previously built the timeline at the manifest
resolution while staging segments are written at the (hidden) half-res
sampling size, so ffmpeg's overlay pasted the smaller segments into the
top-left quarter of a black full-res canvas and the combine's restore
gate saw frames already at the manifest size and never fired.
- compose_h3_project_video now probes the timeline segments and composes
at the size they all share (_uniform_probed_size; manifest dims remain
the fallback for mixed/unknown sizes)
- restore_project_video_resolution (utils/rtx_vsr.py) fast-probes the
composed file, and when it differs from the manifest decodes once,
upscales (RTX VSR, Lanczos fallback, exact size) and rebuilds the
video so VIDEO, images, audio and fps all carry the editor-selected
resolution; any failure keeps the original video
- the restore lives in the base combine so MoxieCombine (images slot)
and the legacy GetVideoComponents wiring are both covered; the
duplicated images gate in MoxieCombine is gone
Single-pass projects condition and sample at exactly half the
editor-selected resolution (plain integer halving, no dimension
policies). Moxie Project Video Combine restores the exact editor
resolution on the combined frames right before its images output,
driven by the fresh project manifest so a stale frontend widget can
never misgate it.
- utils/rtx_vsr.py: RTX VSR core (Apache 2.0, from
Comfy-Org/Nvidia_RTX_Nodes_ComfyUI) + Lanczos fallback; the gate is
simply 'frames differ from the manifest resolution'
- nodes/project.py: halve first-pass dims for single mode only;
dual-pass, SelfLift, passthrough and audio-only keep the editor size
- moxie_combine.py: restore before the images output
- scripts/test_rtx_upscale_integration.py: 17 standalone checks
Single-pass MultiTrack projects now condition and sample at half the
editor-selected resolution; Moxie Project Video Combine restores the
exact editor resolution on the combined frames before export, so the
editor resolution remains what the user sees and gets.
- utils/rtx_vsr.py (new): RTX Video Super Resolution core adapted from
Comfy-Org/Nvidia_RTX_Nodes_ComfyUI (Apache 2.0) driving the optional
nvidia-vfx package per frame, with automatic Lanczos fallback and
exact-size correction; owns the sampling-dimension policy and the
project_data gating so only half-res signatures are upscaled
- nodes/project.py: gate half-res conditioning/sampling to single-pass
mode (dual-pass, SelfLift, passthrough, audio-only unchanged)
- moxie_combine.py: restore editor resolution right before the images
output; VIDEO preview output passthrough unchanged
- scripts/test_rtx_upscale_integration.py: standalone sanity checks
(no ComfyUI/torch needed) for the dimension policy and gating
MultiTrack and H3 conditioning cache logging printed Chinese labels
(ProjectMedia/SegmentMedia statuses, timing and cache-size breakdowns).
Translate every console-facing string to English so the ComfyUI log is
fully English-readable:
- cache status values are now 'cache-hit' / 'first-load' (was Chinese),
including the _all_media_caches_hit sentinel comparison and the
_easy_media_cache_status data written into tracks_info
- cache size breakdown now reads 'file(...)=conditioning(...)+...'
with English category labels
- timing/stage messages, video-track compositing and locked-audio
extraction messages, and llama.cpp install errors are English
- fullwidth '|' in the media_loading timing line replaced with ASCII
- test assertions updated to the new English strings
No behavioral changes beyond the log/status wording; the Chinese
prompt-reference syntax (@图片N etc.) and LLM prompt templates are
intentionally untouched as they are functional.
Newer ComfyUI builds lock registered v3 node classes after registration
(comfy_api internal __setattr__ guard), so _apply_lora writing
cls._loaded_lora raised: Cannot modify class attribute '_loaded_lora'
on locked class 'MoxieMultimediaLoaderClone'.
The (path, sd, metadata) cache now lives at module level, which the
locking mechanism does not touch. Test monkeypatch updated to match.
The Moxie model set is MiniMax H3-only, so no other model choices are
exposed in the editor:
- Moxie Multimedia Loader: removed the clip_type dropdown (which listed
every CLIPType recipe in ComfyUI). The H3 Qwen3-VL text encoder is now
always loaded with CLIPType.MINIMAX; older ComfyUI builds raise a
clear error instead of silently loading the wrong encoder.
- Moxie Multimedia Loader: outputs are now exactly model, clip,
video_vae, audio_vae - the legacy FAST_MODEL_LOADER (model_loader)
bundle output is removed. The model output keeps the attention
backend and LoRA applied.
- Moxie MultiTrack Project: takes model, clip, video_vae and audio_vae
as required direct inputs instead of a bundled model_loader; the
fallback plumbing is removed while EasyMultiTrackProject keeps its
model_loader input for non-Moxie workflows.
- Moxie Preview Override: dropped the model_loader pass-through slots
and patches the model input directly.
- Moxie-consolidated.json reference workflow updated to the new slots.
- Added tests/test_moxie_nodes.py covering the schema contracts, the
attention -> LoRA -> output chain, the MINIMAX lock and the project
loader synthesis.
The upstream locales/zh/nodeDefs.json is not part of this repository,
so every test reading it failed at runtime. Guard all 16 call sites
with pytest.skip and add a tests/conftest.py that stubs folder_paths
so collection works outside a full ComfyUI installation.