Dropping ffmpeg.exe into python_embeded (next to python.exe) is a common
Windows support instruction; scan sys.executable's folder after the
portable root and CWD candidates.
Windows PATH edits only reach processes started afterwards, so a freshly
installed FFmpeg stays invisible to a running ComfyUI, and portable users
often drop ffmpeg.exe next to the run bat without any PATH entry at all.
get_ffmpeg_path now probes, after which() fails: the classic C:\ffmpeg\bin
and %LOCALAPPDATA% locations, winget Links / scoop shims / chocolatey bin,
the ComfyUI base folder and portable root (root, bin/, ffmpeg/bin/), and
finally the ffmpeg binary bundled with ComfyUI's own imageio-ffmpeg
dependency (ffmpeg only - imageio-ffmpeg bundles no ffprobe).
The H3 compose failure message now also points at concrete remedies
instead of only listing search locations.
Verified with scripts/test_merge_failure_reason.py: 19/19 stubbed checks
(portable-layout resolution, imageio-ffmpeg last resort, ffprobe exclusion,
and every compose failure reason).
merge_video_track_with_ffmpeg returned None for every failure mode (FFmpeg
missing, empty timeline, odd canvas, missing segment/locked-audio files,
spawn errors, non-zero exit), which collapsed into the useless
'FFmpeg could not compose the H3 project video' message users saw in the
ComfyUI error dialog.
Add an opt-in failure_reason collector: callers that need to surface the
cause (compose_h3_project_video) now pass a list and receive one specific
human-readable entry per failed precondition, or the FFmpeg stderr tail
(e.g. 'Unknown encoder libx264') when the command itself fails. The
nodes/basic.py tensor-merge fallback still uses the silent None contract
and is unchanged.
Verified with scripts/test_merge_failure_reason.py (16 stubbed checks:
every return-None path records a reason, compose propagates it).
- frontend/src + messages restored byte-identical to upstream v1.3.3:
format normalization shims, isMoxieEditorFormat gates, bundle marker,
tooltip reword, and their tests all removed; editor bundle rebuilt from
that pristine source so the editor behaves exactly like upstream
- format combo shows 'MiniMax' again (options=[MiniMax]); legacy queued
'Moxie Multimedia' values still normalized to MiniMax at execution
- T2V resolves natively again: t2v stays t2v in h3_task_type,
_multitrack_task_type and getMultiTrackTaskType; generation-mode t2v
mapping and the zero-media cloud fallback removed (upstream behavior);
Python tests and stub scripts updated accordingly
- editor delivery fix: core lets WEB_DIRECTORY overwrite the pack's
EXTENSION_WEB_DIRS entry, so the /extensions listing never contained
dist/release and a fresh browser never imported the editor (it only
ever appeared from stale browser cache). web/js/editor-loader.js now
imports the editor entry from the pack's own static mount, which
serves index.js with no-cache (chunks stay cacheable); the
/extensions/<pack>/index.js route was removed as a 404 trap
- shipped Moxie*.json templates carry format value MiniMax
Verified: frontend diff vs upstream = 0; bundle string checks + chunk
refs; vitest 565/566 (same pre-existing jsdom URL.revokeObjectURL env
failure); py_compile; test_t2v_r2v_and_loader.py ALL PASS;
test_rtx_upscale_integration.py ALL PASS
- T2V selections (editor default mode, explicit [start-end,t2v] override
tags, raw t2v values) now resolve to r2v in every task-type resolver
(h3_task_type, _multitrack_task_type, frontend getMultiTrackTaskType);
h3_generation_mode maps raw t2v to reference conditioning as belt and
braces. Reference-mode with zero reference media renders text-only
locally; the cloud path falls back to its native t2va request instead
of raising. i2v/l2v/v2v/edit flows unchanged.
- MoxieMultimediaLoader now presents a single model picker: LoRA, video
VAE, audio VAE, and CLIP widgets removed and auto-selected from the
pack's models/ folders (first sorted file, loud error when missing,
LoRA applied at strength 1.0 when bundled). Outputs and load order
unchanged; saved workflows keep working (extra widget values ignored).
Verified: py_compile; scripts/test_t2v_r2v_and_loader.py 50/50;
frontend vitest 566/567 (one pre-existing env failure on HEAD);
bun run build; scripts/test_rtx_upscale_integration.py all pass.
- the format combo on MultiTrack Editor and MultiTrack Project now
shows 'Moxie Multimedia' (FORMAT_DISPLAY_LABEL); every queued value
is normalized back to the internal 'MiniMax' value at both execute
entries and check_lazy_status, so tracks_info, conditioning caches,
saved manifests and frontend lookups are unchanged
- frontend: normalizeFormatValue() maps the display label back at the
format-widget read point so MiniMax-specific editor features keep
working; shipped templates carry the new label
- removed the per-run 'Output upscale' console line; the restore now
happens silently (one-shot fallback diagnostics kept)
Note: workflows saved before this change need the format re-picked
once, since 'MiniMax' is no longer a combo option.
The compose step previously built the timeline at the manifest
resolution while staging segments are written at the (hidden) half-res
sampling size, so ffmpeg's overlay pasted the smaller segments into the
top-left quarter of a black full-res canvas and the combine's restore
gate saw frames already at the manifest size and never fired.
- compose_h3_project_video now probes the timeline segments and composes
at the size they all share (_uniform_probed_size; manifest dims remain
the fallback for mixed/unknown sizes)
- restore_project_video_resolution (utils/rtx_vsr.py) fast-probes the
composed file, and when it differs from the manifest decodes once,
upscales (RTX VSR, Lanczos fallback, exact size) and rebuilds the
video so VIDEO, images, audio and fps all carry the editor-selected
resolution; any failure keeps the original video
- the restore lives in the base combine so MoxieCombine (images slot)
and the legacy GetVideoComponents wiring are both covered; the
duplicated images gate in MoxieCombine is gone
Single-pass projects condition and sample at exactly half the
editor-selected resolution (plain integer halving, no dimension
policies). Moxie Project Video Combine restores the exact editor
resolution on the combined frames right before its images output,
driven by the fresh project manifest so a stale frontend widget can
never misgate it.
- utils/rtx_vsr.py: RTX VSR core (Apache 2.0, from
Comfy-Org/Nvidia_RTX_Nodes_ComfyUI) + Lanczos fallback; the gate is
simply 'frames differ from the manifest resolution'
- nodes/project.py: halve first-pass dims for single mode only;
dual-pass, SelfLift, passthrough and audio-only keep the editor size
- moxie_combine.py: restore before the images output
- scripts/test_rtx_upscale_integration.py: 17 standalone checks
Single-pass MultiTrack projects now condition and sample at half the
editor-selected resolution; Moxie Project Video Combine restores the
exact editor resolution on the combined frames before export, so the
editor resolution remains what the user sees and gets.
- utils/rtx_vsr.py (new): RTX Video Super Resolution core adapted from
Comfy-Org/Nvidia_RTX_Nodes_ComfyUI (Apache 2.0) driving the optional
nvidia-vfx package per frame, with automatic Lanczos fallback and
exact-size correction; owns the sampling-dimension policy and the
project_data gating so only half-res signatures are upscaled
- nodes/project.py: gate half-res conditioning/sampling to single-pass
mode (dual-pass, SelfLift, passthrough, audio-only unchanged)
- moxie_combine.py: restore editor resolution right before the images
output; VIDEO preview output passthrough unchanged
- scripts/test_rtx_upscale_integration.py: standalone sanity checks
(no ComfyUI/torch needed) for the dimension policy and gating
MultiTrack and H3 conditioning cache logging printed Chinese labels
(ProjectMedia/SegmentMedia statuses, timing and cache-size breakdowns).
Translate every console-facing string to English so the ComfyUI log is
fully English-readable:
- cache status values are now 'cache-hit' / 'first-load' (was Chinese),
including the _all_media_caches_hit sentinel comparison and the
_easy_media_cache_status data written into tracks_info
- cache size breakdown now reads 'file(...)=conditioning(...)+...'
with English category labels
- timing/stage messages, video-track compositing and locked-audio
extraction messages, and llama.cpp install errors are English
- fullwidth '|' in the media_loading timing line replaced with ASCII
- test assertions updated to the new English strings
No behavioral changes beyond the log/status wording; the Chinese
prompt-reference syntax (@图片N etc.) and LLM prompt templates are
intentionally untouched as they are functional.