Commit Graph

5 Commits

Author SHA1 Message Date
Z User
01946fa657 fix: harden every H3 sizing entry point against off-grid API canvases
The 2026-10-16 user crash report (544x960 project, reshape '[1, 24, 1, 1,
15, 2, 8, 2]' invalid for input of size 12240) decodes to a keyframe
conditioning latent of 272x480/16: the raw, unaligned half-res first pass
that e83beb1 already floors onto the 32px grid. The crashing install runs
a pre-fix pack build (the workflow's embedded pack hash is not on main),
so the reported trace itself is stale-build behavior - users must update
the pack and restart ComfyUI.

This commit closes the two remaining paths that could still feed an odd
latent to comfy's patchify_video:

- EasyMultiTrackProject now floors info width/height onto CANVAS_MULTIPLE
  right after parsing tracks_info. The MultiTrack Editor only offers grid
  sizes, but external app clients inject project dimensions through the
  ComfyUI API and could send any value; media loading, reference encoding,
  both sampling passes and exports now agree on one aligned canvas
  (no-op for every editor-selected size).
- MiniMaxH3ReferenceToVideoFallback grid-aligns reference video frames
  before vae.encode, matching what comfy core's native node already does
  on builds that ship H3 (the fallback only registers on older builds).

Adds regression tests: the 544x960 single-pass first pass must condition
at 256x480, off-grid API dimensions (530x964) must align to 512x960 with
a 1.25x second pass at 640x1216, and the reference fallback must encode
off-grid ref videos on the grid.
2026-10-16 18:45:53 +00:00
Z User
e83beb18bd fix: keep every H3 canvas on the 32px grid (odd-latent patchify crash)
Users on 960x544 / 544x960 projects (and 8 more single-pass editor
resolutions) crashed on the first sampling step: the hidden half-res
first pass produced an odd latent side and comfy core's patchify_video
could not split it into 2x2 patches. Floor the half-res first pass onto
CANVAS_MULTIPLE and align width/height at every H3 conditioning entry
point; also make the 'No H3 task segments' error actionable.

Applied verbatim from the external app team's verified fix brief
(HF main 2026-10-16): fixed files match the brief's reference md5s
(e98df714fba97074938f372891802caa / 0bc6cc304fcc45ff1b335539b6ff9e44),
py_compile clean, shape-math checks 10/10. Users must update the pack
and restart ComfyUI.
2026-10-15 19:16:24 +00:00
Z User
fc040c1645 feat: translate all cache/task console logs to English
MultiTrack and H3 conditioning cache logging printed Chinese labels
(ProjectMedia/SegmentMedia statuses, timing and cache-size breakdowns).
Translate every console-facing string to English so the ComfyUI log is
fully English-readable:

- cache status values are now 'cache-hit' / 'first-load' (was Chinese),
  including the _all_media_caches_hit sentinel comparison and the
  _easy_media_cache_status data written into tracks_info
- cache size breakdown now reads 'file(...)=conditioning(...)+...'
  with English category labels
- timing/stage messages, video-track compositing and locked-audio
  extraction messages, and llama.cpp install errors are English
- fullwidth '|' in the media_loading timing line replaced with ASCII
- test assertions updated to the new English strings

No behavioral changes beyond the log/status wording; the Chinese
prompt-reference syntax (@图片N etc.) and LLM prompt templates are
intentionally untouched as they are functional.
2026-09-26 23:27:09 +00:00
Z User
27041a8a9f feat: scrub EasyMedia/MiniMax branding from all user-facing output
Console, errors, tooltips, descriptions and display names no longer
reveal the pack heritage or the underlying model family:

- [EasyMedia]/[Easy Media] console prefixes -> [Moxie] (11 files)
- New console privacy filter (utils/log.py, installed at pack import):
  rewrites MiniMax variants in every displayed logging record, including
  ComfyUI core lines like 'Model MiniMaxH3 prepared for dynamic VRAM
  loading', %-args and matching tracebacks. api.minimaxi.com is protected
  so cloud-API errors stay accurate.
- Node display names rebranded (node_ids untouched, workflows safe):
  'MiniMax H3 To Video' -> 'Moxie To Video', etc.
- ~40 error/tooltip/description strings reworded to Moxie terms.
- CLIP error no longer names CLIPType.MINIMAX; test match updated.

Unchanged on purpose (breaking if touched): node_ids/class names,
combo value 'MiniMax' (workflow payloads), internal dict keys
(minimax_keyframes/minimax_refs), llm_api cloud provider strings,
class-name logic checks, source-only docstrings.
2026-09-26 23:05:24 +00:00
4ea8431cd0 init
Some checks are pending
Publish to Comfy registry / Publish Custom Node to registry (push) Waiting to run
2026-09-26 11:11:23 -07:00