feat: make feature dependencies mandatory (RTX 3060+ audience)
The pack targets NVIDIA RTX 3060+ GPUs only, so speech (voxcpm), subtitle recognition (openai-whisper, qwen-asr) and the RTX VSR upscale (nvidia-vfx) move from on-demand extras into requirements.txt. Verified on PyPI: all four resolve, torchcodec ships Windows wheels for python 3.10-3.14, and the qwen-asr transformers==4.57.6 pin is compatible with the rest of the set. requirements.txt is ordered light -> heavy so re-running the install resumes cleanly.
This commit is contained in:
parent
84b02cf8ac
commit
e7a288de1a
@ -6,7 +6,7 @@
|
||||
|
||||
### ⚡ Improvements
|
||||
|
||||
- **Installation**: The pack now ships a **`requirements.txt`**, so ComfyUI Manager installs the feature-level dependencies automatically and manual/portable installs have a one-line command (`python_embeded\python.exe -m pip install -r ...` for ComfyUI Portable — see the new "Installing dependencies" section in the README). The list covers `soundfile`, `jieba`, `huggingface_hub`, `ffmpeg-python`, `opencv-python`, and `imageio`; heavier extras (`voxcpm`, `openai-whisper`, `qwen-asr`, `nvidia-vfx`) stay optional and are installed on demand with clear error messages.
|
||||
- **Installation**: The pack now ships a **`requirements.txt`**, so ComfyUI Manager installs the dependencies automatically and manual/portable installs have a one-line command (`python_embeded\python.exe -m pip install -r ...` for ComfyUI Portable — see the new "Installing dependencies" section in the README). Because this pack targets **NVIDIA RTX 3060+ GPUs only**, every feature dependency is mandatory: `soundfile`, `jieba`, `huggingface_hub`, `ffmpeg-python`, `opencv-python`, `imageio` (smart split), `nvidia-vfx` (RTX VSR upscale), `openai-whisper` and `qwen-asr` (subtitle recognition), and `voxcpm` (speech). No optional extras remain — previously these were installed on demand with error messages naming the missing package.
|
||||
- **Installation**: Removed the bundled `download_models.sh` downloader. All model files live in the Hugging Face version of the repository — cloning it downloads the complete model set, so there is no separate downloader step (the README's Models section now explains this).
|
||||
- **MultiTrack Editor**: The editor frontend was **reverted to the pristine upstream v1.3.3 source** — the MiniMax/Moxie format display-label mapping and every workaround built around it were removed. The shipped editor bundle is now built from that pristine source, so its behavior is exactly the battle-tested upstream editor (Shot/Context continuity, reference-size, audio lock, and MiniMax prompt placeholders all key on the native `MiniMax` format value again).
|
||||
- **Editor delivery fix**: A fresh browser could previously end up without the editor bundle entirely. ComfyUI core lets a pack's `WEB_DIRECTORY` overwrite its extension web-dir registration, so the browser's `/extensions` listing only ever contained this pack's helper scripts — never the editor entry — and the editor only appeared from stale browser cache. A small static loader (`web/js/editor-loader.js`, served with the helpers) now imports the editor entry from the pack's own route, which serves `index.js` with `no-cache` so the entry is always revalidated while its content-hashed chunks stay cacheable. After updating: restart ComfyUI and reload the page once; no cache-clearing gymnastics required.
|
||||
|
||||
10
README.md
10
README.md
@ -38,14 +38,8 @@ pip install -r Your_ComfyUI_Path/custom_nodes/Moxie-Multimedia/requirements.txt
|
||||
|
||||
Restart ComfyUI afterwards.
|
||||
|
||||
Optional features install their extra dependencies on demand and show a clear error message naming the missing package:
|
||||
|
||||
| Feature | Extra to install |
|
||||
|---|---|
|
||||
| Speech / voiceover generation | `pip install voxcpm` |
|
||||
| Subtitle recognition (local Whisper) | `pip install openai-whisper` |
|
||||
| Subtitle recognition (Qwen ASR) | `pip install qwen-asr` |
|
||||
| RTX VSR upscale (NVIDIA only) | `pip install nvidia-vfx` |
|
||||
> [!NOTE]
|
||||
> The pack targets **NVIDIA RTX 3060+ GPUs only**, so every feature dependency is mandatory and installed by the command above — including speech generation (`voxcpm`), subtitle recognition (`openai-whisper`, `qwen-asr`), and the RTX Video Super Resolution upscale (`nvidia-vfx`). Expect a sizable first install: `qwen-asr` pins `transformers==4.57.6` (pip may upgrade it inside your ComfyUI environment) and `voxcpm` needs `torch>=2.5.0`, so keep ComfyUI reasonably current. If the command is interrupted, re-run it — it resumes where it stopped.
|
||||
|
||||
### Models
|
||||
|
||||
|
||||
@ -4,11 +4,21 @@
|
||||
# If you cloned the pack manually, install it yourself - see README.md
|
||||
# ("Installing dependencies") for the ComfyUI Portable command.
|
||||
#
|
||||
# Only feature-level dependencies are listed here. Core stack (torch,
|
||||
# numpy, Pillow, PyYAML, aiohttp) comes with ComfyUI itself, and every
|
||||
# heavier extra (speech, ASR, RTX upscale) is imported lazily with a
|
||||
# clear error message telling you what to install - see the optional
|
||||
# extras table in README.md.
|
||||
# This pack targets NVIDIA RTX 3060+ GPUs only, so every feature
|
||||
# dependency ships as mandatory - speech, subtitle recognition, and the
|
||||
# RTX Video Super Resolution upscale are all installed up front. The
|
||||
# list is ordered light -> heavy: if a large package ever fails to
|
||||
# install, everything above it is already in place and re-running the
|
||||
# command resumes.
|
||||
#
|
||||
# Notes:
|
||||
# - Core stack (torch, numpy, Pillow, PyYAML, aiohttp) comes with
|
||||
# ComfyUI itself.
|
||||
# - qwen-asr pins transformers==4.57.6 / accelerate==1.12.0, so pip may
|
||||
# upgrade those two packages inside your ComfyUI environment.
|
||||
# - voxcpm needs torch>=2.5.0 and torchcodec (wheels exist for Windows
|
||||
# and Linux, python 3.10-3.14); keep ComfyUI reasonably current.
|
||||
# - ffmpeg-python drives the FFmpeg binary - keep FFmpeg in PATH.
|
||||
|
||||
# Audio: reading/writing merged and generated audio
|
||||
soundfile
|
||||
@ -27,3 +37,15 @@ opencv-python
|
||||
|
||||
# Smart split (dataset loaders)
|
||||
imageio
|
||||
|
||||
# RTX Video Super Resolution upscale (NVIDIA RTX GPUs only)
|
||||
nvidia-vfx
|
||||
|
||||
# Subtitle recognition (local Whisper)
|
||||
openai-whisper
|
||||
|
||||
# Subtitle recognition (Qwen ASR) - pins transformers==4.57.6
|
||||
qwen-asr
|
||||
|
||||
# Speech / voiceover generation (VoxCPM)
|
||||
voxcpm
|
||||
|
||||
Loading…
Reference in New Issue
Block a user