From 84b02cf8ac8ca0025360cbcc4180dc8767b46c9c Mon Sep 17 00:00:00 2001 From: Z User Date: Mon, 28 Sep 2026 22:19:29 +0000 Subject: [PATCH] docs: drop download_models.sh, point Models section at the HF repo The downloader script is removed; all model files live in the Hugging Face version of the repository, so cloning it is the only step needed. CHANGELOG also records the new requirements.txt from the previous commit. --- CHANGELOG.md | 2 + README.md | 6 +-- download_models.sh | 116 --------------------------------------------- 3 files changed, 3 insertions(+), 121 deletions(-) delete mode 100755 download_models.sh diff --git a/CHANGELOG.md b/CHANGELOG.md index 54a962d..d088cca 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,8 @@ ### ⚡ Improvements +- **Installation**: The pack now ships a **`requirements.txt`**, so ComfyUI Manager installs the feature-level dependencies automatically and manual/portable installs have a one-line command (`python_embeded\python.exe -m pip install -r ...` for ComfyUI Portable — see the new "Installing dependencies" section in the README). The list covers `soundfile`, `jieba`, `huggingface_hub`, `ffmpeg-python`, `opencv-python`, and `imageio`; heavier extras (`voxcpm`, `openai-whisper`, `qwen-asr`, `nvidia-vfx`) stay optional and are installed on demand with clear error messages. +- **Installation**: Removed the bundled `download_models.sh` downloader. All model files live in the Hugging Face version of the repository — cloning it downloads the complete model set, so there is no separate downloader step (the README's Models section now explains this). - **MultiTrack Editor**: The editor frontend was **reverted to the pristine upstream v1.3.3 source** — the MiniMax/Moxie format display-label mapping and every workaround built around it were removed. The shipped editor bundle is now built from that pristine source, so its behavior is exactly the battle-tested upstream editor (Shot/Context continuity, reference-size, audio lock, and MiniMax prompt placeholders all key on the native `MiniMax` format value again). - **Editor delivery fix**: A fresh browser could previously end up without the editor bundle entirely. ComfyUI core lets a pack's `WEB_DIRECTORY` overwrite its extension web-dir registration, so the browser's `/extensions` listing only ever contained this pack's helper scripts — never the editor entry — and the editor only appeared from stale browser cache. A small static loader (`web/js/editor-loader.js`, served with the helpers) now imports the editor entry from the pack's own route, which serves `index.js` with `no-cache` so the entry is always revalidated while its content-hashed chunks stay cacheable. After updating: restart ComfyUI and reload the page once; no cache-clearing gymnastics required. - **MultiTrack Editor / MultiTrack Project**: **T2V resolves natively again** (`t2v` stays `t2v`, matching upstream) — the model now handles text-to-video with the updated prompting, so the earlier T2V→R2V normalization was removed from the editor type computation, `h3_task_type`, `_multitrack_task_type`, and the generation-mode mapping. The reference-mode-with-zero-media cloud fallback was removed accordingly (reference mode raises for missing media again, as upstream). diff --git a/README.md b/README.md index da89b51..b9884a0 100644 --- a/README.md +++ b/README.md @@ -60,11 +60,7 @@ All model files ship **inside the repo** — cloning it into `custom_nodes` is a | Turbo LoRA (`MM3step.safetensors`, applied by default) | `models/loras/` | | Preview tiny VAE (`MM-preview.safetensors`) | `models/vae_approx/` | -If you obtained the pack without the bundled files, the included downloader fetches and places them (idempotent and resumable — re-run if interrupted): - -```bash -bash custom_nodes/MMnode/download_models.sh -``` +All model files live in the Hugging Face version of this repository — cloning it downloads the complete set, and there is no separate downloader step. If you obtained the pack from somewhere else and the `models/` folders are missing or incomplete, re-clone from Hugging Face to get the bundled files. Restart ComfyUI afterwards. diff --git a/download_models.sh b/download_models.sh deleted file mode 100755 index 2a1be5b..0000000 --- a/download_models.sh +++ /dev/null @@ -1,116 +0,0 @@ -#!/usr/bin/env bash -# -# download_models.sh - fetch the MiniMax H3 model set for the Moxie Multimedia -# Loader and place it (renamed) into this node pack's models/ folders. -# -# Usage (from anywhere - the script targets its own pack directory): -# bash custom_nodes/MMnode/download_models.sh -# -# Files are downloaded to ".part" first and moved into place when -# complete, so an interrupted run can be re-run safely (it resumes). -# Already-complete files are skipped, so the script is idempotent. - -set -euo pipefail - -SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" -MODELS_DIR="$SCRIPT_DIR/models" - -# --------------------------------------------------------------------------- -# Model manifest: subdir/filename <- URL -# Add the turbo LoRA here once a URL is available, e.g.: -# "loras/Moxie-Turbo.safetensors|https://.../Moxie-Turbo.safetensors" -# --------------------------------------------------------------------------- -MANIFEST=( - "diffusion/Moxie-Multimedia.safetensors|https://huggingface.co/WarmBloodAban/Minimax-h3_Singularity/resolve/main/Minimax-h3_Singularity_ref2va_v1.3_Pruned_w4a8.safetensors" - "clip/MM-VL.safetensors|https://huggingface.co/Comfy-Org/MiniMax-H3/resolve/main/text_encoders/qwen3vl_32b_minimax_h3_nvfp4_awq.safetensors" - "vae/video_vae.safetensors|https://huggingface.co/Comfy-Org/MiniMax-H3/resolve/main/vae/minimax_h3_video_vae_int8_convrot.safetensors" - "audio_vae/audio_vae.safetensors|https://huggingface.co/Comfy-Org/MiniMax-H3/resolve/main/vae/minimax_h3_audio_vae_fp32.safetensors" -) - -# --------------------------------------------------------------------------- -# Downloader: curl first (resume via -C -), wget as fallback. -# --------------------------------------------------------------------------- -curl_supports_retry_all() { - # --retry-all-errors exists since curl 7.71.0; compare versions safely. - local v - v="$(curl --version 2>/dev/null | head -n1 | awk '{print $2}')" - [[ "$(printf '%s\n7.71.0\n' "$v" | sort -V | head -n1)" == "7.71.0" ]] -} - -fetch() { - local url="$1" output="$2" - if command -v curl >/dev/null 2>&1; then - local retry_all="" - if curl_supports_retry_all; then - retry_all="--retry-all-errors" # HuggingFace answers bursts with 429/503 - fi - curl -L --fail --retry 5 --retry-delay 5 $retry_all \ - --connect-timeout 30 -C - -o "$output" "$url" - elif command -v wget >/dev/null 2>&1; then - wget -c -q --show-progress -O "$output" "$url" - else - echo "ERROR: neither curl nor wget is installed." >&2 - return 1 - fi -} - -download_entry() { - local entry="$1" - local rel="${entry%%|*}" - local url="${entry#*|}" - local subdir="${rel%%/*}" - local filename="${rel#*/}" - local target_dir="$MODELS_DIR/$subdir" - local target="$target_dir/$filename" - local partial="$target.part" - - if [[ -f "$target" ]]; then - echo "[skip] $subdir/$filename already present" - return 0 - fi - - mkdir -p "$target_dir" - echo "[get ] $subdir/$filename" - echo " from $url" - - if ! fetch "$url" "$partial"; then - # A stale/incomplete .part can make resume fail (e.g. HTTP 416 when the - # file was already fully fetched but the move never happened). - if [[ -f "$partial" ]]; then - echo " resume failed - deleting partial and restarting download" - rm -f "$partial" - fetch "$url" "$partial" - else - return 1 - fi - fi - - mv -f "$partial" "$target" - echo "[done] $subdir/$filename ($(du -h "$target" | cut -f1))" -} - -echo "Moxie Multimedia - model downloader" -echo " pack models dir: $MODELS_DIR" -echo - -failed=0 -for entry in "${MANIFEST[@]}"; do - if ! download_entry "$entry"; then - echo "ERROR: failed to download $entry" >&2 - failed=1 - fi -done - -echo -if [[ "$failed" -eq 0 ]]; then - echo "All models ready:" - for entry in "${MANIFEST[@]}"; do - local_rel="${entry%%|*}" - printf ' %-40s %s\n' "$local_rel" "$(du -h "$MODELS_DIR/$local_rel" 2>/dev/null | cut -f1 || echo missing)" - done - echo - echo "Restart ComfyUI so the loader picks the files up." -else - echo "Some downloads failed - re-run this script to resume." >&2 - exit 1 -fi